Skip to content

feat: Allow wrapping of tournament names in ResultsTable - #7711

Draft
mbergen wants to merge 3 commits into
mainfrom
results-tournament-name
Draft

feat: Allow wrapping of tournament names in ResultsTable#7711
mbergen wants to merge 3 commits into
mainfrom
results-tournament-name

Conversation

@mbergen

@mbergen mbergen commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

Allows tournament names to wrap in ResultsTable.
On desktop, this avoids the results table being too wide to fit on a screen without scrolling while only breaking very long names;
on mobile, this reduces the amount of vertical scroll needed with the compromise of higher rows for most cases, as almost all names will wrap.

How did you test this change?

dev/salt on https://liquipedia.net/ageofempires/TheViper

@mbergen
mbergen requested review from a team as code owners June 30, 2026 08:17
@ElectricalBoy

Copy link
Copy Markdown
Collaborator

Screenshot_20260630_173042_Chrome.png

imo this introduces too much wrapping in mobile which is arguably worse than the current behavior

@mbergen

mbergen commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

imo this introduces too much wrapping in mobile which is arguably worse than the current behavior

Is it? I personally would prefer being able to read a tournament name in one go without needing to scroll sideways.
(Arguably the display is bad on mobile anyways, as by default i only see date and tier and not even the tournament)

We can add a min-width (e.g. 250px) to the name cell if that helps.

@ElectricalBoy

Copy link
Copy Markdown
Collaborator

We can add a min-width (e.g. 250px) to the name cell if that helps.

yeah that sounds like a reasonable middle ground

@bvanessen93

Copy link
Copy Markdown

We can add a min-width (e.g. 250px) to the name cell if that helps.

yeah that sounds like a reasonable middle ground

I don’t mind adding a wrapper but not at the expense of multiple lines. Two would be fine, three is definitely pushing it. That would be the limit. Not sure if the 250px would fix this but if not I’d prefer to truncate the tournament name at 250px.
Screenshot 2026-07-06 at 11 20 19

@mbergen
mbergen marked this pull request as draft July 7, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants