feat: Add module to list available factions#7816
Open
mbergen wants to merge 12 commits into
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
mbergen
marked this pull request as ready for review
July 19, 2026 11:46
hjpalpha
reviewed
Jul 19, 2026
hjpalpha
left a comment
hjpalpha
left a comment
Collaborator
There was a problem hiding this comment.
- should use widget v3 instead of v2
- for wikis that don't have game specific versions (i.e. all but aoe) this won't work well, maybe add a (bool) option input param
|byGame=truefor that? (if set to false use default game without box, if set to true use Game.listGames)
Collaborator
Author
Works perfectly fine on wikis that have only a single game. Now SC2 is different as you configure different games (versions)? |
hjpalpha
reviewed
Jul 19, 2026
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
hjpalpha
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lists all defined factions (by game) with icons, aliases and key.
How did you test this change?
Live on https://liquipedia.net/ageofempires/Module:Faction/Data/doc (Depends on #7813)