Skip to content

feat(match2): grid-based match summary for fighters#7828

Merged
Rathoz merged 5 commits into
mainfrom
fighters-ms-grid
Jul 21, 2026
Merged

feat(match2): grid-based match summary for fighters#7828
Rathoz merged 5 commits into
mainfrom
fighters-ms-grid

Conversation

@ElectricalBoy

Copy link
Copy Markdown
Collaborator

@ElectricalBoy
ElectricalBoy requested review from a team July 20, 2026 07:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Fighters wiki match summary to use the shared grid-based MatchSummaryWidgets.GameRow/GamesContainer layout, aligning Fighters with other wikis that render match summaries as structured rows rather than bespoke widget rows.

Changes:

  • Replaced the previous per-game Row widget construction with MatchSummaryWidgets.GamesContainer + MatchSummaryWidgets.GameRow.createComponent(...).
  • Moved game overview and opponent rendering into GameRowComponentProps implementations (createGameOverview, createGameOpponentView, getGameOpponentViewCss).
  • Added Fighters-specific prop typing annotations to support the new row component’s data needs (gameData, matchOpponents, soloMode).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lua/wikis/fighters/MatchSummary.lua
@ElectricalBoy
ElectricalBoy requested a review from Rathoz July 21, 2026 00:38
@Rathoz
Rathoz merged commit 8f6eb01 into main Jul 21, 2026
8 checks passed
@Rathoz
Rathoz deleted the fighters-ms-grid branch July 21, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants