Skip to content

Adding ENC Team History#7830

Open
reidthesloth wants to merge 1 commit into
Liquipedia:mainfrom
reidthesloth:patch-3
Open

Adding ENC Team History#7830
reidthesloth wants to merge 1 commit into
Liquipedia:mainfrom
reidthesloth:patch-3

Conversation

@reidthesloth

Copy link
Copy Markdown
Contributor

Players are wanting ENC nation history shown like FIFAe is on their pages

Tested: https://liquipedia.net/rocketleague/User:Reidthesloth/ENC/Player_Card/Test

Test Module: https://liquipedia.net/rocketleague/Module:Infobox/Person/Player/Custom/dev/Reidthesloth (can be nuked after if needed)

Players are wanting ENC nation  history shown like FIFAe is on their pages 

Tested: https://liquipedia.net/rocketleague/User:Reidthesloth/ENC/Player_Card/Test

Test Module: https://liquipedia.net/rocketleague/Module:Infobox/Person/Player/Custom/dev/Reidthesloth (can be nuked after if needed)
@reidthesloth
reidthesloth requested review from a team as code owners July 20, 2026 14:56

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this further increases infobox player

not a fan

@reidthesloth

Copy link
Copy Markdown
Contributor Author

this further increases infobox player

not a fan

players asked as it been added in past for FIFIAe, IWO, and Gfinity Elite Series.

if there is a better way for us to show this let us know and if we should remove them i am down for it.

@mbergen

mbergen commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

players asked

Did any user ask that is not on one of these teams? :)

@hjpalpha

Copy link
Copy Markdown
Collaborator

just thinking out loud but maybe making it collapsible might be a good idea
(same for team history in general)

@reidthesloth

Copy link
Copy Markdown
Contributor Author

players asked

Did any user ask that is not on one of these teams? :)

Sadly, there were others that were not players that asked for this as well. I know if you commentators I speak to enjoy the idea (I really need to stop asking other people for feedback).

@reidthesloth

Copy link
Copy Markdown
Contributor Author

just thinking out loud but maybe making it collapsible might be a good idea

(same for team history in general)

If we can, that'd be great, especially With how some rocket league players turn coaches have long ass history

@reidthesloth

Copy link
Copy Markdown
Contributor Author

Also, something I just noticed is apparently we still have the old upcoming matches built into the template I don't fully know Where the line of code is to remove it, but just to put it on the radar lol image

@steve020607

Copy link
Copy Markdown
Contributor

Also, something I just noticed is apparently we still have the old upcoming matches built into the template I don't fully know Where the line of code is to remove it, but just to put it on the radar lol image

Being called on https://liquipedia.net/rocketleague/Module:Infobox/Person/Player/Custom on line 274 that called Module:MatchTicker from Module:Matches Player

@mbergen

mbergen commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Also, something I just noticed is apparently we still have the old upcoming matches built into the template I don't fully know Where the line of code is to remove it, but just to put it on the radar lol image

Being called on https://liquipedia.net/rocketleague/Module:Infobox/Person/Player/Custom on line 274 that called Module:MatchTicker from Module:Matches Player

...when the match ticker is so old it is missed when the "old" matchticker gets removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants