refactor: flatten nesting in IngestEventQueue to satisfy Credo#3515
Merged
Conversation
nelsonmestevao
force-pushed
the
ne/ingest-event-queue
branch
from
81f6a55 to
c15c431
Compare
- Extract `add_to_target_table/2` to replace inline chunking lambdas in `add_to_table/3` (consolidated and sid/bid clauses). - Extract `fetch_events_or_empty/2` from the `for`-loop body in `fetch_events/2`. - Extract `select_to_insert/4` from `do_truncate_table/3`, with a zero-arity head clause replacing the inline `if n == 0`.
nelsonmestevao
force-pushed
the
ne/ingest-event-queue
branch
from
c15c431 to
55626bb
Compare
Ziinc
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_to_target_table/2to replace inline chunking lambdas inadd_to_table/3(consolidated and sid/bid clauses).fetch_events_or_empty/2from thefor-loop body infetch_events/2.select_to_insert/4fromdo_truncate_table/3, with a zero-arity head clause replacing the inlineif n == 0.