Add per-tool ignoreArchCheck field to Tool#37
Merged
albertodebortoli merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Allows each tool in the Lucafile to override the global --ignore-arch-check CLI flag via an `ignoreArchCheck: Bool?` field. Precedence: per-tool true/false beats the CLI flag; nil falls back to it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
Add per-tool ignoreArchCheck field to Tool
Description
ignoreArchCheck: Bool?property toTool, allowing each tool in the Lucafile to override the global--ignore-arch-checkCLI flag.truealways skips arch validation; per-toolfalsealways runs it;nil(field absent from YAML) falls back to the CLI flag.Type of Change
How Has This Been Tested?
Four new installer tests cover all precedence scenarios:
test_install_perToolIgnoreArchCheck_true_overridesGlobalFalse— per-tooltruebeats globalfalsetest_install_perToolIgnoreArchCheck_false_overridesGlobalTrue— per-toolfalsebeats globaltruetest_install_perToolIgnoreArchCheck_nil_fallsBackToGlobal_skips—nil+ globaltrue→ no throwtest_install_perToolIgnoreArchCheck_nil_fallsBackToGlobal_validates—nil+ globalfalse→ throwsChecklist
Breaking Changes?
Additional Notes
Three new fixture files were added under
Tests/Fixtures/Lucafiles/for the per-tool tests. NoPackage.swiftchanges needed — theFixturesdirectory is already registered as a resource.