Add version check in post-checkout hook#8
Merged
albertodebortoli merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Check installed luca version against .luca-version on branch checkout, triggering a reinstall when there is a mismatch. Also fixes the shell_hook idempotent PATH test to match only the project-specific .luca/tools entry, avoiding false positives when luca is installed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
post-checkoutnow checks the installed luca version against.luca-versionon every branch checkout, triggering a reinstall when they don't matchis_luca_version_correct()helper alongsideis_luca_installed()installed: vX, required: vY) when an update is triggeredshell_hook.batswhere the idempotent PATH test used a broad grep pattern (\.luca/tools) that matched the user's real~/.luca/toolsinstall, causing a false count of 2Test plan
post_checkout.bats: version matches (no reinstall), version mismatch (triggers update with message), no.luca-versionfile (skips check)bats tests/→ 54/54.luca-versionand verify the mismatch message appears🤖 Generated with Claude Code