fix issue 733#740
Open
meubleancien wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #733
Removed the
pandas<3.0.4cap (PR #732), which was a segfault workaround; the real constraint wasnumba, sinceshappulls innumbaand everynumbarelease declaresnumpy<2.5. Setpandas>=2.2.2,<4.0.0,numpy>=2.0.0,<2.5.0(matching what numba actually supports), and raised thenumbafloor to >=0.64.0 (first release supportingnumpy 2.4.x);numba 0.66.0also now guards thenumpyversion with a cleanImportErrorinstead of segfaulting.Verified against the reported segfault combo (
pandas 3.0.3,numpy 2.4.6,numba 0.66.0,shap 0.52.0): 539 unit + 16 integration tests pass and end-to-end SmartExplainer.compile runs with no segfault.Note:
numpystays effectively capped at 2.4.x bynumba, so bump thenumbafloor and numpy ceiling together once a futurenumbaadds 2.5 support.