Clean up test-generated artifacts tracked in git#741
Open
milton-minervino wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests were leaking build/test artifacts into the repo instead of using ephemeral storage.
test_load_smartpredictor_1wrote its round-trip pickle directly into the trackedtests/data/directory, keyed by interpreter version (predictor_to_load_<pyver>.pkl) — every Python version bump left a new untracked file. Fixed to usetempfile.TemporaryDirectory(), matching the pattern already used by the neighboringTestSmartPredictorManifesttest.predictor_to_load_{38,39,310}.pkl) that were accidental commits from past interpreter upgrades and weren't read by any test.catboost_info/gitignore pattern (was root-anchored/catboost_info/) so it also matches thecatboost_info/dumps CatBoost writes when executing tutorial notebooks (e.g.tutorial/generate_webapp/,tutorial/plots_and_charts/), not just one at the repo root.testfile at the repo root.No production code changes;
tests/data/metadata.yaml,clean_titanic.pkl, andclean_titanic_pandas_3.pklwere confirmed to be genuine input fixtures (read-only, loaded by multiple tests) and left untouched. XGBoost/LightGBM were checked and confirmed not to write similar disk artifacts on.fit(), so no further gitignore changes were needed there.Type of change
How Has This Been Tested?
pytest: all tests passed, no leaked artifacts.Test Configuration: