fix(windows): reject legacy converter wrapper - #20
Merged
VincentAdamNemessisX merged 1 commit intoJul 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The tester package was launching the temporary v0.0.3 compatibility wrapper as
tools\mh3g-save-convert.exe, not the native 0.0.4 Rust CLI. The screenshot textUnable to prepare patched user saveexists only in that wrapper. Its core-input preflight also expects4 + 0x8A00bytes while a valid Japanese 3DSuser1is exactly0x8A00, so it exits before the Rust core and emits no JSON.Fix
mh3g-save-convert-core.exemarker and returns a direct bilingual rebuild instruction before launchVerification
ConverterCliClient.csand rejected a marker-bearing fixturegit diff --checkpassedA real WinUI/XAML packaging run remains a Windows-host gate. CI is intentionally not awaited because Actions quota is unavailable.