Skip to content

fix(windows): reject legacy converter wrapper - #20

Merged
VincentAdamNemessisX merged 1 commit into
mainfrom
fix/mh3g-windows-reject-legacy-wrapper
Jul 29, 2026
Merged

fix(windows): reject legacy converter wrapper#20
VincentAdamNemessisX merged 1 commit into
mainfrom
fix/mh3g-windows-reject-legacy-wrapper

Conversation

@VincentAdamNemessisX

Copy link
Copy Markdown
Contributor

Root cause

The tester package was launching the temporary v0.0.3 compatibility wrapper as tools\mh3g-save-convert.exe, not the native 0.0.4 Rust CLI. The screenshot text Unable to prepare patched user save exists only in that wrapper. Its core-input preflight also expects 4 + 0x8A00 bytes while a valid Japanese 3DS user1 is exactly 0x8A00, so it exits before the Rust core and emits no JSON.

Fix

  • WinUI scans the selected sidecar for the legacy mh3g-save-convert-core.exe marker and returns a direct bilingual rebuild instruction before launch
  • Windows packaging rejects the same marker both after Rust build and after ZIP extraction
  • bilingual docs map the exact screenshot error to the stale-wrapper package and provide the one supported rebuild path

Verification

  • RED source contract failed before the guard existed, then passed after implementation
  • cross-platform .NET 8 harness compiled the real ConverterCliClient.cs and rejected a marker-bearing fixture
  • Windows WinUI source contract passed
  • Rust converter: 190 tests passed
  • Windows MSVC target check passed
  • strict Clippy passed
  • bilingual docs contract and git diff --check passed

A real WinUI/XAML packaging run remains a Windows-host gate. CI is intentionally not awaited because Actions quota is unavailable.

@VincentAdamNemessisX
VincentAdamNemessisX requested a review from a team as a code owner July 29, 2026 12:49
@VincentAdamNemessisX
VincentAdamNemessisX merged commit 533b065 into main Jul 29, 2026
3 of 5 checks passed
@VincentAdamNemessisX
VincentAdamNemessisX deleted the fix/mh3g-windows-reject-legacy-wrapper branch July 29, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant