fix(converter): fail closed without transaction evidence - #35
Merged
Conversation
VincentAdamNemessisX
force-pushed
the
feat/converter-transaction-evidence
branch
from
August 7, 2026 02:31
a522321 to
178e9ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Passed locally
swift test --package-path apps/mh3g-save-converter-macos: 63 tests, 0 failuresswift build -c release --package-path apps/mh3g-save-converter-macos: PASScargo test -p mh3g-save-convert: 205 tests across 8 suites PASSwrite_then_rollback_restores_previous_slot: PASS with source-byte/source-SHA invariance and restored-target SHA assertionscargo fmt --all -- --check: PASSgit diff --check: PASSBlocked / Unverified
Stack