fix(converter): align MH3G guide and appearance records - #36
Merged
Conversation
* feat(converter): add native release update checks * fix(converter): avoid GitHub API rate-limit failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repair-convertedto repair those fields only when the current Wii U value still equals the historical converter outputsystemconversion at the CLI boundary with a two-input shared-data mergesystemand an existing initialized Cemusystem, union only gallery/movie flags, and preserve every other Cemu bytesystemis shared by all three slotsOfficial-transfer evidence and exact boundary
The supplied archive was unpacked only under
/tmp; no real save is committed. Five independently paired Japanese 3DS -> Wii U official-transfer slots were compared against a fresh conversion from this branch.For all five pairs:
0x65C4..0x6684(48 guide records) matches the official Wii U result byte-for-byte0x73B8,0x73BC,0x73C8,0x73D0, and0x73D8match byte-for-byte0.0.6, repaired 48-53 non-palindromic fields depending on the save, and produced the same bytes as a fresh fixed conversionThis is targeted-field exactness, not whole-file identity. The five converted
user#payloads still differ from the supplied official results by 288, 255, 258, 270, and 215 bytes respectively in fields outside this PR's proven mapping. All four quest files matched the official samples before this change and remain untouched.Shared
systemdecisionGallery/movie flags live in the shared
systemcomponent, not the selecteduser#. Because that file can also carry settings and data shared by the other slots, the converter now:systemand target as Japanese Cemusystem;0x44..0x53;0x68..0x77with the correct endianness;The one supplied source/target
systemsample does not behave as a trustworthy whole-payload official parity oracle, so this is deliberately reported as format/transaction evidence rather than gameplay proof.Root cause
u32guide table and a mixed-layout appearance cluster.uint8_t, so negative points render as 248-255, and its armor writer rebuilds the header without preserving RGB bytes.system; copying a whole source file would risk unrelated slot/settings data, while converting onlyuser#cannot migrate it at all.Verification
cargo test -p mh3g-save-convert— 215 passedx86_64-pc-windows-msvcClippy with-D warnings— passedswift test— 64 passedconvert-systemdry-run on the supplied 3DS/Cemu sample — passed without modifying either filegit diff --check— passedRuntime boundary
Cemu was not launched. This is targeted official-transfer byte parity plus system format/transaction and synthetic UI verification, not gameplay runtime verification. Native Windows WinUI compilation/runtime remains for a Windows host.