Skip to content

fix: Remove race condition during multi-GPU training #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uermel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Remove race condition during multi-GPU training #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07c3ae4
fix DDP race
uermel Jun 9, 2026
298deb1
less verbose comment, remove potential silent error
uermel Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ddw/utils/unet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ def update_hparam(self, hparam, value):
"""
Update a hyperparameter in the hparams.yaml file.
"""
# DDP-safe: only the global-zero rank writes hparams.yaml.
if getattr(self, "global_rank", 0) != 0:
return
logger = self.trainer.logger
logdir = f"{logger.save_dir}/{logger.name}/version_{logger.version}"
hparams_file = f"{logdir}/hparams.yaml"
Expand Down