fix: msu serde complains due to null strings in metadata emulator#489
Open
LordMidas wants to merge 1 commit intodevelopmentfrom
Open
Conversation
In a new campaign, the Name, ModificationData, CreationDate and FileName are all null in the real metadata. This causes no issues in vanilla as it accepts nulls into `writeString`. But this means that any SerDe done using MSU SerDe emulators on a new campaign will throw complaints about null being stored into String data container.
TaroEld
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a new campaign, the Name, ModificationData, CreationDate and FileName are all null in the real metadata. This causes no issues in vanilla as it accepts nulls into
writeString. But this means that any SerDe done using MSU SerDe emulators on a new campaign will throw complaints about null being stored into String data container.