Skip to content

fix(onboarding): address permission and content clipping issues (#282) #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cassio-rossi merged 2 commits into from
Apr 30, 2026
Merged

fix(onboarding): address permission and content clipping issues (#282) #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
400cf95
fix(onboarding): skip push permission prompt on Mac (Designed for iPad)
cassiorossi1010 Apr 30, 2026
043f3ab
fix(onboarding): increase features page height to prevent content cli…
cassiorossi1010 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...e/Features/OnboardingLibrary/Sources/OnboardingLibrary/ViewModels/PermissionManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ public final class PermissionManager {

/// Check current push notification permission status from system
func checkPushPermissionStatus() async {
if ProcessInfo.processInfo.isiOSAppOnMac {
currentPushStatus = .authorized
return
}

let status = await PushNotification.authorizationStatus
currentPushStatus = status
}
Expand Down
7 changes: 1 addition & 6 deletions ...ine/Features/OnboardingLibrary/Sources/OnboardingLibrary/Views/Screen2_FeaturesView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ struct FeaturesView: View {
}
.containerRelativeFrame([.horizontal, .vertical])
.overlay(alignment: .topTrailing) {
// Skip button - acts like a toolbar
OnboardingSkipButton(
label: "Pular novidades",
hint: "Vá direto para a tela de permissões"
Expand All @@ -72,7 +71,6 @@ struct FeaturesView: View {
.animation(.easeInOut(duration: 0.25), value: isLastPage)
.allowsHitTesting(!isLastPage)
}
// .background(OnboardingBackground())
.onAppear { animateIn = true }
.onDisappear { animateIn = false }
.trackScreen(AnalyticsConstants.Screen.onboardingFeatures.name, analytics: coordinator.analytics)
Expand Down Expand Up @@ -111,7 +109,6 @@ struct FeaturesView: View {

private var landscapeLayout: some View {
HStack(spacing: 20) {
// Left side - Logo and title
VStack(spacing: 8) {
logoView
Text("Novidades no app")
Expand All @@ -122,7 +119,6 @@ struct FeaturesView: View {
}
.frame(width: 120)

// Right side - Cards and footer
VStack(spacing: 0) {
Spacer()

Expand All @@ -131,7 +127,6 @@ struct FeaturesView: View {

Spacer()

// Footer at bottom: dots centered, or dots left + button right
HStack {
if isLastPage {
pageIndicator
Expand Down Expand Up @@ -186,7 +181,7 @@ struct FeaturesView: View {
if isIPad {
return 260
}
return 300
return 320
}

private func pageView(cards: [OnBoardingFeature]) -> some View {
Expand Down
Loading