fix(settings): fix InApp purchase not updating removeAds environment#294
Merged
cassio-rossi merged 1 commit intorelease/v5from May 2, 2026
Merged
Conversation
Replace broken 100ms polling loop with proper withObservationTracking + continuation pattern that suspends until InAppManager.status mutates. Make process(purchased:) async to eliminate fire-and-forget Task race condition where DB save never completed before status reset. Add defensive .onChange(of: isValidSubscription) in SubscriptionView to ensure environment updates even if ModelContext.didSave is missed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubscriptionViewModel.setupListeners()with properwithObservationTracking+withCheckedContinuationthat suspends untilInAppManager.statusmutatesprocess(purchased:)fullyasyncto eliminate fire-and-forget Task race condition where DB save never completed before status reset.onChange(of: viewModel.isValidSubscription)inSubscriptionViewto ensureremoveAdsenvironment updates even ifModelContext.didSavenotification is missedTest plan
--strict🤖 Generated with Claude Code