This repository was archived by the owner on Nov 30, 2025. It is now read-only.
319 replacing redundant waterloo api logic in relation to converttermcodetotermname#327
Merged
sai3000pro merged 3 commits intomainfrom Feb 13, 2025
Conversation
Contributor
Author
|
I just commented the code out for now - I can delete it if that's more preferred! |
Member
|
yeah let's delete - keeps things cleaner that way! if we need it again we can just pull from the git history |
some-molasses
approved these changes
Feb 12, 2025
Member
some-molasses
left a comment
some-molasses
left a comment
There was a problem hiding this comment.
approving anyway but deleting is preferred!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commented out the functions that no longer worked due to the API not working. Appears to work normally on my local version! We might want to add in validation that works later, though.