Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Documentation-only update with no unresolved review issues.
Review effort: Lite
Findings: None
What changed in this PR
Updates RBAC documentation to mark Argo CD Renovate tag tracking as complete.
Changes:
- References the Renovate configuration and upgrade procedure.
- Retains manual ClusterRole reconciliation guidance.
| File | Description |
|---|---|
docs/rbac-layers.md |
Marks Argo CD Renovate tracking as completed and documents the remaining review step. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The "Open hardening TODOs" section in
docs/rbac-layers.mdlists Renovatetracking of the upstream Argo CD tag as outstanding, under Operability:
Why this is stale
This is already implemented.
renovate.json5has acustomManagersregexentry that tracks exactly this file:
It matches the pinned tag in
argo-setup/patches/kustomization.yaml(
raw.githubusercontent.com/argoproj/argo-cd/v3.3.11/manifests/ha/install.yaml)and opens the bump PR automatically. The item just above it in the same doc
(CI diff check for upstream ClusterRoles) was marked done when it landed;
this one wasn't updated to match.
Change
Updates the TODO entry to reflect that it's done, and points to
renovate.json5and theBumping Argo CDprocedure inargo-setup/README.mdfor the manual review step (ClusterRole diffreconciliation) that still applies after Renovate opens the bump PR.
Testing
Docs-only change no code, manifests, or CI affected. Verified the
regex in
renovate.json5against the live line inargo-setup/patches/kustomization.yamland confirmed it matches.