fix: OCR follow-ups for analysis validation, Exaflow errors and folder locks - #29
Open
KFilippopolitis wants to merge 4 commits into
Open
KFilippopolitis wants to merge 4 commits into
KFilippopolitis wants to merge 4 commits into
Conversation
Require analysis.algorithm and analysis.inputdata before using them, so a malformed request is a 400 instead of a 500. Authorize validation_datasets as well as datasets on both the synchronous and persisted execution paths.
Convert experiment.algorithm rows written in the old AlgorithmExecutionDTO shape into AnalysisRequestDTO before the new reader sees them, so existing experiments no longer fail GET /experiments with a Gson type error.
… key Check the HTTP status before parsing specification responses, log the specific failure instead of re-wrapping it, and avoid an NPE when an error response has no body. Emit the Exaflow parameter key "default" through Jackson as well as Gson.
Rename and delete were the only mutations reading the folder without findByIdForUpdate, leaving them exposed to a concurrent delete/set update race. Use the same locked read as the other write paths.
KFilippopolitis
force-pushed
the
fix/ocr-review
branch
from
September 15, 2026 13:28
85344ef to
617d46a
Compare
KFilippopolitis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slim version of the OCR review follow-up, limited to defects and security/data-integrity guards.
analysis.algorithm/inputdataand authorizevalidation_datasets.experiment.algorithmpayloads toAnalysisRequestDTO.defaultparameter key through Jackson as well as Gson.Dropped as non-essential: exception/logging refactors, folder DTO rename/grouping, UUID trimming, OIDC/config and README tweaks, Jackson/Gson documentation.
Verification:
mvn clean packagepasses 65/65 tests; V3 exercised end-to-end with Flyway 13.6 against PostgreSQL 18.