Skip to content

release geodifflib on shutdown() for macOS #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harminius wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

release geodifflib on shutdown() for macOS #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pygeodiff/geodifflib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,16 @@ def __del__(self):
self.shutdown()

def shutdown(self):
if self.lib is not None:
lib = getattr(self, "lib", None)
if lib is not None:
Comment on lines +77 to +78

@wonder-sk wonder-sk Sep 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ugly... better to init self.lib = None in the __init__() instead of this

if platform.system() == "Windows":
from _ctypes import FreeLibrary

FreeLibrary(self.lib._handle)
FreeLibrary(lib._handle)
else:
from _ctypes import dlclose

dlclose(lib._handle)
self.lib = None

def _register_functions(self):
Expand Down
Loading