Feature/feature drafts - #4652
Open
xkello wants to merge 3 commits into
Open
Conversation
Coverage Report for CI Build 32107333826Coverage decreased (-0.5%) to 58.633%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions531 previously-covered lines in 8 files lost coverage.
Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
Withalion
reviewed
Aug 20, 2026
Withalion
left a comment
Withalion
left a comment
Collaborator
There was a problem hiding this comment.
Great job, it looks very promising! There are some trivial things, a bit more refactoring is needed, but mainly unit tests.
UI/UX
- It would be nice to navigate to the geometry you will be recording further after you open the draft
- After user is done recording geometry and doesn't fill out anything in the form yet, application crashes. We should open the form right away and not the geometry recording
- When a draft is available and an existing feature is clicked to edit the warning drawer opens and closes right away
- When a draft is available and "add" button is clicked, the drawer opens correctly, but discarding draft doesn't start recording mode, but stays in "view" mode of map
| ShowSwitchWorkspaceAction, | ||
| ShowSyncFailedDialog | ||
| ShowSyncFailedDialog, | ||
| OpenDraftAction |
Collaborator
There was a problem hiding this comment.
Suggested change
| OpenDraftAction | |
| ShowDraftAction |
let's keep the naming convention
|
|
||
| secondaryButton.text: qsTr( "Do not discard" ) | ||
|
|
||
| onPrimaryButtonClicked: { |
Collaborator
There was a problem hiding this comment.
Suggested change
| onPrimaryButtonClicked: { | |
| onPrimaryButtonClicked: () => { |
| close() | ||
| } | ||
|
|
||
| onSecondaryButtonClicked: { |
Collaborator
There was a problem hiding this comment.
Suggested change
| onSecondaryButtonClicked: { | |
| onSecondaryButtonClicked: () => { |
| signal discardClicked() | ||
|
|
||
| imageSource: __style.neutralMMSymbolImage | ||
| title: featureTitle !== "" |
Collaborator
There was a problem hiding this comment.
Suggested change
| title: featureTitle !== "" | |
| title: featureTitle |
| setDraft( false ); | ||
|
|
||
| if ( wkt.isEmpty() ) | ||
| return QgsGeometry(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| return QgsGeometry(); | |
| return {}; |
| #ifndef FEATUREDRAFTSTORAGE_H | ||
| #define FEATUREDRAFTSTORAGE_H | ||
|
|
||
| #include <QString> |
Collaborator
There was a problem hiding this comment.
Suggested change
| #include <QString> |
| #include <QSettings> | ||
| #include <QJsonDocument> | ||
|
|
||
| const QString FeatureDraftStorage::QSETTINGS_DRAFTS_GROUP_NAME = QStringLiteral( "featureDrafts" ); |
Collaborator
There was a problem hiding this comment.
declaring the literal should be enough here, you don't have to declare it in the class as well
|
|
||
| if ( raw.isEmpty() ) | ||
| { | ||
| return QJsonObject(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| return QJsonObject(); | |
| return {}; |
Collaborator
There was a problem hiding this comment.
as probably mentioned elsewhere the data of draft should be stored during runtime as a structure and this class should do the conversion between structure and QSettings friendly format. Other classes don't need to know how it's stored
Withalion
reviewed
Aug 20, 2026
Withalion
left a comment
Withalion
left a comment
Collaborator
There was a problem hiding this comment.
Great job, it looks very promising! There are some trivial things, a bit more refactoring is needed, but mainly unit tests.
UI/UX
- It would be nice to navigate to the geometry you will be recording further after you open the draft
- After user is done recording geometry and doesn't fill out anything in the form yet, application crashes. We should open the form right away and not the geometry recording
- When a draft is available and an existing feature is clicked to edit the warning drawer opens and closes right away
- When a draft is available and "add" button is clicked, the drawer opens correctly, but discarding draft doesn't start recording mode, but stays in "view" mode of map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds automatic recovery of in-progress feature edits. If the app closes unexpectedly while you're editing a feature - a crash, an incoming call, a dead battery - your unsaved geometry and attribute changes are no longer lost. On the next launch you're offered the chance to resume exactly where you left off, or discard the changes.
Fixes: #4585
What changed
FeatureDraftStorage/FeatureDraftController(app/drafts/) persist an in-progress edit (geometry + attributes) as a JSON blob viaQSettings, debounced by ~1s so it isn't written on every keystroke/vertex.AttributeControllerandRecordingMapToolwrite a draft whenever attributes or geometry are edited, and clear it once the feature is saved, deleted, or the edit is cancelled.ActiveProjectexposes the draft controller to QML.Behaviour
Screen_Recording_20260818-082140_One.UI.Home.mp4
Screen_Recording_20260818-082018_One.UI.Home.mp4
Screen_Recording_20260818-082039.mp4
TLDR @Withalion
Feature edits are now drafted automatically so a crash, call, or dead battery doesn't cost you your unsaved work - surfaced via a notification and resume/discard drawers.