fix: cascade channel_messages on packet delete - #96
Merged
446564 merged 1 commit intoAug 11, 2026
Conversation
446564
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested title: Fix packet retention by adding ON DELETE CASCADE to channel_messages FK
What this PR does
channel_messages.packet_hashreferencespacketswith noON DELETEaction, and nothing ever deletes fromchannel_messages. So any packet carrying a channel message can never age out. SinceDeleteOldPacketsis a single statement, one blocked row kills the whole delete:End result is packet retention silently fails every cleanup tick once your channel traffic is older than your retention window. Easy to miss on a newer deployment since nothing has expired yet. I only found it after lowering retention on a DB that had grown to 83 GB.
Migration 023 recreates the FK with
ON DELETE CASCADE, same aspacket_observationsalready does. Channel messages now age out with their packets. UsedDROP CONSTRAINT IF EXISTSso it stays idempotent if you already patched this by hand.Testing notes
Migration only, so
sqlc generateis a no-op. Verified on a live deployment, both FKs onpacketsnow showconfdeltype = 'c'and the hourly cleanup went from failing every tick to done in a few seconds.Heads up if your DB has been stuck for a while: the first cleanup after the fix does the entire backlog in one statement and can take a long time. Don't restart the app mid purge, it rolls the whole thing back. And plain DELETE doesn't give space back to the OS, so run a
VACUUM FULLafter if you actually want the files to shrink.