Open
Conversation
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
Author
|
@metamaskbot publish-previews |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
hmalik88
commented
Apr 8, 2026
| // Default capabilities — parent updates this when snap metadata is available. | ||
| // We cast here because KeyringCapabilities requires a non-empty scopes array, | ||
| // but we don't have the snap metadata at construction time (e.g. during deserialization). | ||
| this.capabilities = { scopes: [] } as unknown as KeyringCapabilities; |
Contributor
Author
There was a problem hiding this comment.
Will update when there's a new release of snaps-rpc-methods so I can use getKeyringCaveatCapabilities. Safe to leave as it is for now since we're not using capabilities at the moment.
Contributor
Author
|
@metamaskbot publish-previews |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d23a1b9. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
SnapKeyringV2as a per-snap keyring wrapper that implements theKeyringV2interface, establishing a 1:1 relationship between account management snaps and their keyrings.Architecture Diagrams
What changed
SnapKeyringV2implementsKeyringV2withcreateAccount,createAccounts,deleteAccount,submitRequest,getAccount, andgetAccountsSnapKeyringSnapKeyringbecomes a thin router by delegatingcreateAccount,createAccounts, and#deleteAccountto the per-snap wrappernormalizeAccountAddressextracted to shared util (was duplicated)#accountIndexreverse map enables O(1) "which snap owns this account?" lookupsIntegration
Version bump in the clients. The public API of
SnapKeyringis unchanged.What's next
SnapKeyringV2instances directly toKeyringControllerNote
Medium Risk
Refactors core Snap account storage/routing and create/delete flows to go through new per-snap wrappers and a global account-id index, which could affect account ownership resolution and persistence if edge cases are missed. External serialized format is preserved, but deserialize/serialize logic is rewritten and should be validated against existing state.
Overview
Introduces
SnapKeyringV2, a per-snap wrapper implementingKeyringV2(account CRUD +submitRequest) backed by@metamask/keyring-sdk’s registry, and exports it publicly.Refactors
SnapKeyringto replace the flat#accountsmap with per-snap wrappers plus a reverse#accountIndexfor O(1) account-id → snap ownership routing;createAccount,createAccounts, and deletion now delegate to the wrapper, whileserialize/deserializere-group and rebuild wrappers but keep the external persisted format.Moves
normalizeAccountAddressintoutil, adds@metamask/keyring-sdkas a dependency/tsconfig reference, and updates tests (newSnapKeyringV2suite plus adjusted expectations and an unknown-snap case forgetAccountsBySnapId).Reviewed by Cursor Bugbot for commit 8691743. Bugbot is set up for automated code reviews on this repo. Configure here.