feat(keyring-sdk): add generateEthAccountId + use it in EthKeyringWrapper#504
Draft
feat(keyring-sdk): add generateEthAccountId + use it in EthKeyringWrapper#504
generateEthAccountId + use it in EthKeyringWrapper#504Conversation
Base automatically changed from
cc/feat/deterministic-uuid-for-evm-for-keyring-v2
to
main
April 8, 2026 14:38
ccharly
force-pushed
the
cc/feat/deterministic-uuid-for-evm-for-keyring-v2-eth-keyring-wrapper
branch
from
f1f7fd0 to
47c6e37
Compare
ccharly
changed the title
generateEthAccountId + use it in EthKeyringWrapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change how account ID are generate for
EthKeyringWrapperso IDs are now deterministic (similarly to what theAccountsControlleris doing today).