feat(STX-433): add submissionMethod to transaction metadata#8375
Open
rarquevaux wants to merge 1 commit intomainfrom
Open
feat(STX-433): add submissionMethod to transaction metadata#8375rarquevaux wants to merge 1 commit intomainfrom
rarquevaux wants to merge 1 commit intomainfrom
Conversation
7b11078 to
221177a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The goal of this PR is to add a
submissionMethodproperty in the TransactionMetadata object in order to record how the transaction was submitted to the network and add it to the metrics. This datapoint can be recording at submission in the https://github.com/MetaMask/metamask-extension/blob/main/app/scripts/controller-init/confirmations/transaction-controller-init.tsDraft PR on extension to demonstrate the use case: MetaMask/metamask-extension#41465
References
Checklist
Note
Low Risk
Low risk type-only change: adds an optional metadata field and enum export, with no runtime behavior changes, but may require downstream projects to update typings/imports.
Overview
Adds an optional
submissionMethodfield toTransactionMetato record how a transaction was submitted, backed by a newTransactionSubmissionMethodenum (currentlysentinel_stxandsentinel_relay).Exports
TransactionSubmissionMethodfrom the package entrypoint and documents the new metadata field in thetransaction-controllerchangelog.Written by Cursor Bugbot for commit 221177a. This will update automatically on new commits. Configure here.