feat(snap-account-service): add SnapAccountService#8414
Open
feat(snap-account-service): add SnapAccountService#8414
SnapAccountService#8414Conversation
SnapAccountService
david0xd
reviewed
Apr 13, 2026
david0xd
reviewed
Apr 13, 2026
f570e75 to
2963d98
Compare
2963d98 to
61675d0
Compare
auto-merge was automatically disabled
April 15, 2026 12:49
Merge commits are not allowed on this repository
0f03c1f to
7fa0b28
Compare
db372cc to
d43c0ee
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b06e156. Configure here.
david0xd
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
A new service where we will move the common logic of the current monolith
SnapKeyring.The idea is to be able to split this keyring into multiple ones and move the
KeyringEvents logic in this service.High-level architecture is the following:
For now, it's just an empty service, but we will move forward with more follow-up change as we are rewriting the existing
SnapKeyringto use the newKeyringV2.References
N/A
Checklist
Note
Low Risk
Mostly adds a new, unused package scaffold and monorepo wiring; no business logic changes beyond a stub
init()and a basic test.Overview
Adds a new package,
@metamask/snap-account-service, as the initial scaffold for a messenger-basedSnapAccountService(currently no exposed actions/events andinit()is a stub) plus a minimal Jest test thatinit()resolves.Wires the new workspace into the monorepo (root
tsconfigreferences,yarn.lockworkspace entry, CODEOWNERS/teams.jsonownership, and README package list/dependency graph), and includes standard package metadata/docs (README, changelog, license, typedoc/jest/tsconfig configs).Reviewed by Cursor Bugbot for commit 3262a0e. Bugbot is set up for automated code reviews on this repo. Configure here.