Open
Conversation
shane-t
reviewed
Apr 10, 2026
Jwhiles
force-pushed
the
add-chomp-api
branch
4 times, most recently
from
d8926ef to
010ce60
Compare
Jwhiles
force-pushed
the
add-money-account-upgrade-controller
branch
5 times, most recently
from
8b2387c to
2e23109
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
shane-t
reviewed
Apr 15, 2026
shane-t
reviewed
Apr 15, 2026
shane-t
reviewed
Apr 15, 2026
Jwhiles
force-pushed
the
add-money-account-upgrade-controller
branch
from
7bb3882 to
debd7eb
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Jwhiles
force-pushed
the
add-money-account-upgrade-controller
branch
from
debd7eb to
e31c503
Compare
Contributor
Author
|
@metamaskbot publish-preview |
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Jwhiles
force-pushed
the
add-chomp-api
branch
2 times, most recently
from
178d32d to
a820fad
Compare
Jwhiles
force-pushed
the
add-money-account-upgrade-controller
branch
from
9fac52d to
3ad67f2
Compare
Jwhiles
force-pushed
the
add-money-account-upgrade-controller
branch
5 times, most recently
from
320839f to
e0cc75e
Compare
Each step now checks persisted state via #isStepCompleted before running, so a retry after a mid-sequence failure resumes from the last incomplete step rather than re-running everything from scratch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Moves ROOT_AUTHORITY, MAX_UINT256, and STEP_ORDER into constants.ts, and the inline #encodeCaveatTerms private method into a standalone encode-caveat-terms.ts module with direct unit tests. First step in splitting up the growing MoneyAccountUpgradeController file. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Introduces src/steps/ with a StepContext/StepResult/Step type scaffold and a #runStep orchestration helper on the controller that handles the skip check, context build, and state patch merge. The associate-address step is the first extracted — direct unit tests cover its behavior, and the corresponding describe block is removed from the controller tests since orchestration is already covered by the resumability tests. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Introduce a Step type ({ name, run }) with a StepResult union
('already-done' | 'completed') and iterate an internal steps array from
upgradeAccount. Errors from a step propagate and halt the sequence.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Implements step 0 of the Money Account upgrade: signs a fresh
"CHOMP Authentication {timestamp}" message via KeyringController and
submits it to ChompApiService.associateAddress. The endpoint is
idempotent, so the step has no pre-check and always returns 'completed'.
upgradeAccount now takes the account address as a parameter and passes
a { messenger, address } context to each step.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Jwhiles
force-pushed
the
add-money-account-upgrade-controller
branch
from
67bcc7c to
07a2265
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 07a2265. Configure here.
| async upgradeAccount(address: Hex): Promise<void> { | ||
| for (const step of this.#steps) { | ||
| await step.run({ messenger: this.messenger, address }); | ||
| } |
There was a problem hiding this comment.
init result discarded, initialized flag never enforced
Low Severity
The init method fetches and validates service details, sets this.initialized = true, but upgradeAccount never checks the initialized flag before running steps. The initialized property is assigned in the constructor and in init but never read anywhere in the controller's production code — only in tests. This makes it dead code within the controller and means the chain validation performed by init is entirely unenforced; callers can invoke upgradeAccount without init, bypassing all validation.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 07a2265. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds a scaffold for the money account upgrade controller, as well the first step in the upgrade process.
I'll make follow up PRs adding the further steps so they can be reviewed more easily.
Addresses
MUSD-447 and MUSD-449
References
Checklist