fix(transaction-pay-controller): proxy Across status polling via configured api base#8512
Open
pedronfigueiredo wants to merge 1 commit intomainfrom
Open
fix(transaction-pay-controller): proxy Across status polling via configured api base#8512pedronfigueiredo wants to merge 1 commit intomainfrom
pedronfigueiredo wants to merge 1 commit intomainfrom
Conversation
c79b37f to
df5a7ef
Compare
df5a7ef to
c5e3add
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apiBaseinstead of the direct upstream URLdepositTxnRefand acceptfillTxnRefas a terminal transaction hash fallbackconfirmations_payfrom remote feature flags or local overrides, and usehttp://localhost:3000/acrosswhenconfirmations_pay.devis enabled without an explicit Across baseValidation
yarn workspace @metamask/transaction-pay-controller run jest --no-coverage src/strategy/across/across-submit.test.ts src/utils/feature-flags.test.tsyarn eslint packages/transaction-pay-controller/src/strategy/across/across-submit.ts packages/transaction-pay-controller/src/strategy/across/across-submit.test.ts packages/transaction-pay-controller/src/utils/feature-flags.ts packages/transaction-pay-controller/src/utils/feature-flags.test.tsyarn workspace @metamask/transaction-pay-controller run changelog:validateyarn buildNote
Medium Risk
Changes affect Across bridging completion detection and the returned terminal transaction hash, which could impact user-facing transaction tracking if the new status fields/URL behavior differs across environments.
Overview
Across submission now polls the Across deposit status endpoint via the configured
config.across.apiBaseand switches polling to usedepositTxnRef(source tx hash) instead ofdepositId/chain params.Status handling is expanded to treat
fillTxnRefas an additional terminal transaction-hash fallback whendestinationTxHashis missing, and tests/changelog are updated to cover the new polling URL and response fields.Reviewed by Cursor Bugbot for commit c5e3add. Bugbot is set up for automated code reviews on this repo. Configure here.