Skip to content

fix(transaction-pay-controller): proxy Across status polling via configured api base#8512

Open
pedronfigueiredo wants to merge 1 commit intomainfrom
pnf/tpc-proxy-across-status-via-intents
Open

fix(transaction-pay-controller): proxy Across status polling via configured api base#8512
pedronfigueiredo wants to merge 1 commit intomainfrom
pnf/tpc-proxy-across-status-via-intents

Conversation

@pedronfigueiredo
Copy link
Copy Markdown
Contributor

@pedronfigueiredo pedronfigueiredo commented Apr 17, 2026

Summary

  • route Across status polling through the configured Across apiBase instead of the direct upstream URL
  • poll Across deposit status with depositTxnRef and accept fillTxnRef as a terminal transaction hash fallback
  • read confirmations_pay from remote feature flags or local overrides, and use http://localhost:3000/across when confirmations_pay.dev is enabled without an explicit Across base
  • add focused tests and changelog coverage for the new behavior

Validation

  • yarn workspace @metamask/transaction-pay-controller run jest --no-coverage src/strategy/across/across-submit.test.ts src/utils/feature-flags.test.ts
  • yarn eslint packages/transaction-pay-controller/src/strategy/across/across-submit.ts packages/transaction-pay-controller/src/strategy/across/across-submit.test.ts packages/transaction-pay-controller/src/utils/feature-flags.ts packages/transaction-pay-controller/src/utils/feature-flags.test.ts
  • yarn workspace @metamask/transaction-pay-controller run changelog:validate
  • yarn build

Note

Medium Risk
Changes affect Across bridging completion detection and the returned terminal transaction hash, which could impact user-facing transaction tracking if the new status fields/URL behavior differs across environments.

Overview
Across submission now polls the Across deposit status endpoint via the configured config.across.apiBase and switches polling to use depositTxnRef (source tx hash) instead of depositId/chain params.

Status handling is expanded to treat fillTxnRef as an additional terminal transaction-hash fallback when destinationTxHash is missing, and tests/changelog are updated to cover the new polling URL and response fields.

Reviewed by Cursor Bugbot for commit c5e3add. Bugbot is set up for automated code reviews on this repo. Configure here.

@pedronfigueiredo pedronfigueiredo requested review from a team as code owners April 17, 2026 16:35
@pedronfigueiredo pedronfigueiredo self-assigned this Apr 17, 2026
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/tpc-proxy-across-status-via-intents branch from c79b37f to df5a7ef Compare April 17, 2026 16:39
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/tpc-proxy-across-status-via-intents branch from df5a7ef to c5e3add Compare April 17, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant