fix: replace deprecated ActionableMessage with BannerAlert in SnapAccountErrorMessage#43080
Open
TheChyeahhh wants to merge 3 commits into
Open
Conversation
Contributor
|
CLA Signature Action: Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository. 0 out of 1 committers have signed the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Replaces the deprecated
ActionableMessagecomponent withBannerAlertfrom the component-library inSnapAccountErrorMessage.Related Issue
Closes #19528
Changes
ActionableMessagewithBannerAlertusingBannerAlertSeverity.DangerBannerAlertandBannerAlertSeverityfrom component-libraryManual testing
N/A — visual change only (BannerAlert renders similarly to ActionableMessage with type=danger)
Screenshots
N/A
Pre-merge author checklist
Note
Low Risk
Localized UI swaps with no auth, data, or business-logic changes; template
Chip→Tagmay affect Snap-rendered content that referencedChip.Overview
Snap account errors now render inline failures with
BannerAlert(BannerAlertSeverity.Danger) instead of the deprecatedActionableMessage, using component-library imports and the samedata-testid.Home notification pulls
Checkboxfrom the component-library and usesisChecked/onChangeinstead of the legacy checkbox API.Snap template rendering maps the safe component name
ChiptoTagfrom the component-library so templates can use the current tag component.Reviewed by Cursor Bugbot for commit bc18199. Bugbot is set up for automated code reviews on this repo. Configure here.