🐛 fix frontend startup ordering and Ray shm sizing in docker-compose.yml - #530
Open
yuehuiqi wants to merge 2 commits into
Open
🐛 fix frontend startup ordering and Ray shm sizing in docker-compose.yml#530yuehuiqi wants to merge 2 commits into
yuehuiqi wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Datamate Docker Compose deployment to reduce cold-start failures in the frontend and prevent Ray object-store OOMs caused by Docker’s small default /dev/shm.
Changes:
- Add
datamate-gatewaytodatamate-frontend.depends_onto improve startup ordering. - Increase
datamate-runtimeshared memory viashm_size: "10gb". - Set
RAY_DEFAULT_OBJECT_STORE_MEMORY_PROPORTION: "0.5"for Ray indatamate-runtime.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
91
to
94
| depends_on: | ||
| - datamate-gateway | ||
| - datamate-backend | ||
| - datamate-backend-python |
…ce_healthy depends_on only sequenced container start, not readiness -- the frontend could still race the gateway before it was actually accepting connections. Added a healthcheck to datamate-gateway (curl against its own port; there's no Spring Boot Actuator on this image per backend/api-gateway/pom.xml, so a plain "did we get any HTTP response" check is the honest signal available) and switched datamate-frontend's dependency on it to condition: service_healthy. backend/backend-python keep condition: service_started (unchanged behavior).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #529.
datamate-frontendnow also depends ondatamate-gateway, avoiding cold-start failures where the frontend starts before the gateway is reachable.datamate-runtimenow setsshm_size: "10gb"andRAY_DEFAULT_OBJECT_STORE_MEMORY_PROPORTION: "0.5", avoiding Ray object-store OOM under Docker's default 64MB/dev/shm.How tested
Verified the compose file still parses correctly (
yaml.safe_load) and the diff only touches the two services described above -- no other services or the newer log-rotation env vars were affected.