-
Notifications
You must be signed in to change notification settings - Fork 226
[app-platform] Add open source knowledge repo impl. #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.3.x
Are you sure you want to change the base?
[app-platform] Add open source knowledge repo impl. #564
Conversation
|
里程碑和目标分支不匹配 |
fix |
| /** | ||
| * 返回前多少的条目。 | ||
| */ | ||
| @Property(description = "topK", name = "topK") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @Property(description = "topK", name = "topK") | ||
| private Integer topK; | ||
| /** | ||
| * 相关性阈值。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.../main/java/modelengine/fit/jade/datamate/knowledge/knowledge/dto/DataMateRetrievalParam.java
Show resolved
Hide resolved
| * 知识库描述。 | ||
| */ | ||
| private String description; | ||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上,字段间需要换行
| private String createdAt; | ||
| /** | ||
| * 知识库更新时间。 | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上,字段间需要换行
| package modelengine.fit.jade.datamate.knowledge.knowledge.entity; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonIgnoreProperties; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
去除无用空格
|
|
||
| import com.fasterxml.jackson.annotation.JsonIgnoreProperties; | ||
|
|
||
| import lombok.Data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
去除无用空格
|
|
||
| import lombok.Builder; | ||
| import lombok.Data; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
去除无用空格
| private final HttpClassicClientFactory httpClientFactory; | ||
| private final LazyLoader<HttpClassicClient> httpClient; | ||
| private final Map<Integer, KnowledgeManagerRetCode> exceptionMap = new HashMap<>(); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public属性的方法需要添加注释
|
|
||
| private final DataMateKnowledgeBaseManager knowledgeBaseManager; | ||
| private final KnowledgeI18nService knowledgeI18nService; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public属性的方法需要添加注释
| DataMateResponse.from(response, DataMateKnowledgeListEntity.class); | ||
| return Validation.notNull(resp.getData(), "The response body is abnormal."); | ||
| } catch (ClientException ex) { | ||
| log.error(QUERY_KNOWLEDGE_LIST_ERROR.getMsg(), ex.getMessage()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| return Validation.notNull(resp.getData(), "The response body is abnormal."); | ||
| } catch (ClientException ex) { | ||
| log.error(QUERY_KNOWLEDGE_LIST_ERROR.getMsg(), ex.getMessage()); | ||
| throw new KnowledgeException(QUERY_KNOWLEDGE_LIST_ERROR, ex.getMessage()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议在抛出 KnowledgeException时也尽量保留原始异常信息,保留cause


🔗 相关问题 / Related Issue
Issue 链接 / Issue Link: #563
📋 变更类型 / Type of Change
📝 变更目的 / Purpose of the Change
适配DataMate的知识库接口,提供新的知识库实现
📋 主要变更 / Brief Changelog
🧪 验证变更 / Verifying this Change
测试步骤 / Test Steps
测试覆盖 / Test Coverage
📸 截图 / Screenshots
✅ 贡献者检查清单 / Contributor Checklist
请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:
基本要求 / Basic Requirements:
代码质量 / Code Quality:
测试要求 / Testing Requirements:
mvn -B clean package -Dmaven.test.skip=true,npm install --force && npm run build:pro/ Basic checks passmvn clean install/ Unit tests pass文档和兼容性 / Documentation and Compatibility:
📋 附加信息 / Additional Notes
审查者注意事项 / Reviewer Notes: