Fixed stereochemistry of mitsunobu and added corresponding tests - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mitsunobu proceeds by backside attack, so the carbinol carbon inverts. The templates
left that atom unmarked, and RDKit's default is to carry the reactant's configuration
into the product so every stereodefined Mitsunobu product was the wrong enantiomer.
All 60 mitsunobu templates now mark atom map 4 as [#6@:4] on the reactant side and
[#6@@:4] on the product side. RDKit reads differing tags as invert relative to the
input, so one template still covers both input enantiomers and an undefined centre
stays undefined.
These are the only chirality tags in the 9,594 templates, so no other reaction is
affected, confirmed by re-running the full case-study enumeration: mitsunobu
stereochemistry changes, everything else is byte-identical, no products gained or lost.
Tests cover both enantiomers and the undefined case.