recording: recover console-derived run accounts - #150
Merged
Conversation
The council and provider consoles derive their OpEx keys from a wallet signature rather than storing them, and a run's output never records the resulting addresses, so those balances look unreachable once the run ends. Re-deriving them from the run id makes the funds recoverable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the Tranche 3 mainnet run, 48.92 XLM was sitting in accounts that had been written off. The two council OpEx treasuries were missed by the sweep entirely, and Provider Orion's OpEx was recorded as needing a platform-side key it does not actually need.
Neither console stores its operational keys. Both derive them from a single wallet signature:
purpose
opexfor the council console signed by the run admin,ppfor the provider console signed by the operator. Both of those wallets already derive from MASTER_SECRET plus the run id, so a run's OpEx balances are recoverable from the run id alone. Nothing in the run output records the derived addresses, which is why they looked stranded.Every value is required and there are no defaults.
paymentsends the spendable balance and leaves the account open;mergecloses it and recovers the minimum balance too. Nothing is signed until a derived address is confirmed to exist on-chain, and each address and amount is printed before submission.Verified against the Tranche 3 run: it re-derives the exact two addresses recovered by hand today, and now reports them as closed.