fix(cors): allow X-Client-Name/X-Client-Version for browser RPC preflight - #144
Merged
Conversation
…ght passes (release 0.9.17) stellar-sdk sends X-Client-Name/X-Client-Version on RPC calls; production CORS omitted them, so the browser blocked /api/v1/rpc preflight and getAccount failed as 'Account not found'. Add them to Access-Control-Allow-Headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The stellar-sdk RPC client attaches
X-Client-Name/X-Client-Versionheaders to every Soroban RPC request. In production the CORS middleware only allowedContent-Type, Authorization, Traceparent, Tracestate, so the browser's CORS preflight to/api/v1/rpcfailed:The console's
server.getAccount()fetch was blocked before it was sent, and the SDK surfaced it as "Account not found" during council/provider deploys on mainnet. (Testnet ranMODE=development, whose allow-list is*, so it was never hit.)Fix
Add
X-Client-Name, X-Client-Versionto the productionAccess-Control-Allow-Headers. Version bump triggers the mainnet redeploy.Diagnosed via headed browser capture during the mainnet recording rig; server-side RPC calls succeeded, only the browser (CORS-enforced) was blocked.