make take_while function unsafe - #12
Closed
kitcatier wants to merge 1 commit into
Closed
Conversation
Owner
|
Hi, thank you for your input. It is known there are several soundness issues like that one in this crate. I'm also suspecting some safety issues. This is due to me being a beginner when I started it and wanting to prioritize performance over everything else. I have been working on a v2 on another branch that will fix everything. |
Owner
|
Closing in favor of #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I found a soundness issue in this crate.
email-parser/email-parser/src/parsing/combinators.rs
Lines 85 to 100 in 0e72550
The unsafe function called needs to ensure that the parameter must be:
https://doc.rust-lang.org/std/str/fn.from_utf8_unchecked.html
When the parameter condition panics, the input will be saved as non-utf8, which may cause undefined behavior in multi-threaded programs. The developer who calls the take_while function may not notice this safety requirement.
Marking them unsafe also means that callers must make sure they know what they're doing.