Skip to content

Update payment handling payment intents#667

Merged
mitchelljkotler merged 19 commits into
masterfrom
update-payment-handling-payment-intents
Jun 11, 2026
Merged

Update payment handling payment intents#667
mitchelljkotler merged 19 commits into
masterfrom
update-payment-handling-payment-intents

Conversation

@mitchelljkotler

Copy link
Copy Markdown
Member

This switches from using charges directly to payment intents. This allows 3DS credit card security to work.

https://docs.stripe.com/payments/3d-secure

@allanlasser allanlasser temporarily deployed to squarelet-pi-update-pay-k0aefl May 1, 2026 19:43 Inactive
@duckduckgrayduck duckduckgrayduck temporarily deployed to squarelet-pi-update-pay-zf4omh May 4, 2026 19:13 Inactive
@duckduckgrayduck

Copy link
Copy Markdown
Contributor

I tested via the upgrade flow in the user's profile "Upgrade button" and everything worked

@allanlasser allanlasser linked an issue May 18, 2026 that may be closed by this pull request
@mitchelljkotler mitchelljkotler force-pushed the update-payment-handling-stripe-lib branch from 12392b5 to eea8abf Compare May 20, 2026 17:12
@allanlasser allanlasser marked this pull request as ready for review June 1, 2026 18:06
@mitchelljkotler mitchelljkotler changed the base branch from update-payment-handling-stripe-lib to master June 2, 2026 19:35
@mitchelljkotler mitchelljkotler force-pushed the update-payment-handling-payment-intents branch from cfed298 to 005478b Compare June 2, 2026 19:47
@duckduckgrayduck duckduckgrayduck temporarily deployed to squarelet-pi-update-pay-az2hhf June 8, 2026 14:58 Inactive
@duckduckgrayduck

duckduckgrayduck commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

I try to use a 3DS card in on-boarding (not signed in, go to /selectplan/ and select a plan, create an account and then go to that payment page) and it fails. I reach an error page and see this Sentry error:
https://muckrock.sentry.io/issues/7459522941/?project=1247105&query=is%3Aunresolved&referrer=issue-stream

Same transaction succeeds if I log in and click "Upgrade" and use that flow.

@mitchelljkotler mitchelljkotler temporarily deployed to squarelet-pi-update-pay-az2hhf June 9, 2026 14:36 Inactive
@mitchelljkotler mitchelljkotler temporarily deployed to squarelet-pi-update-pay-az2hhf June 9, 2026 14:45 Inactive
@duckduckgrayduck

Copy link
Copy Markdown
Contributor

I'm getting intermittent "A network error occurred. Please try again." messages, which I think may be due to the fact that we are on staging. I did confirm that the confirmation box now loads in the onboarding flow. Authorizing it and failing the authorization are both handled.

@mitchelljkotler mitchelljkotler merged commit 2f78a04 into master Jun 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Stripe code from Charges to PaymentIntents

3 participants