Fail the build when a template fails to build - #524
Open
danielchalmers wants to merge 1 commit into
Open
Conversation
InstallAndBuildAllTemplates.ps1 runs 52 dotnet commands and never checks an exit code between them. A non-zero exit from a native command is not a PowerShell error, so the script runs to the end regardless, and the step reports the exit code of the last build only. A template breaking anywhere except the final permutation therefore leaves mudblazor-ci green. The last 30 runs have all passed. Setting ErrorActionPreference and PSNativeCommandUseErrorActionPreference makes the first failing dotnet command terminate the script.
Member
Author
|
Holding this until the SQLitePCLRaw advisory is resolved upstream. #525 proposed pinning the package in the template; that was closed in favour of waiting for EF Core, since the pin would become stale as soon as upstream moves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstallAndBuildAllTemplates.ps1runs 52dotnetcommands and never checks an exit code between them. A non-zero exit from a native command is not a PowerShell error, so$ErrorActionPreferencedoes not catch it, and the step's exit code is whatever the last command returned.If
InteractivityServer_Authbreaks at permutation 5 of 26,WasmStandalone_CallsWebApisucceeding at the end still turns the job green.The last 30
mudblazor-ciruns are 30/30 success. For a workflow that compiles 26 generated projects with/warnaserroragainst a moving MudBlazor dependency, that record is more suspicious than reassuring.