fix(mcp): inject default namespace for memwal_remember_bulk calls - #667
Open
ducnmm wants to merge 1 commit into
Open
fix(mcp): inject default namespace for memwal_remember_bulk calls#667ducnmm wants to merge 1 commit into
ducnmm wants to merge 1 commit into
Conversation
ducnmm
requested review from
HoangDucBach and
nikola0x0
and removed request for
HoangDucBach
August 17, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #625 (and companion #611)
Summary
Includes
memwal_remember_bulkin the set ofNAMESPACE_TOOLSso the configured default namespace (--namespace/MEMWAL_NAMESPACE) is injected when an agent calls bulk remember without an explicit namespace.Problem
Previously,
NAMESPACE_TOOLSinpackages/mcp/src/bridge.tsonly includedmemwal_remember,memwal_recall,memwal_analyze, andmemwal_restore. When an agent invokedmemwal_remember_bulkwithout an explicitnamespace, no namespace argument was injected and the batch was written into the relayer's fallbackdefaultnamespace, making it unrecallable from the configured project namespace.Changes
"memwal_remember_bulk"toNAMESPACE_TOOLSinpackages/mcp/src/bridge.ts.packages/mcp/test/default-namespace.test.mjsto verify default namespace injection behavior formemwal_remember_bulkand other tools.Verification
pnpm --filter @mysten-incubation/memwal-mcp test(14/14 tests pass)