Skip to content

REST API Error Handling Improvements & Import of dtnma-tools SQL concurrency fix#322

Open
DavidEdell wants to merge 9 commits intomainfrom
305-rest-api-error-handling
Open

REST API Error Handling Improvements & Import of dtnma-tools SQL concurrency fix#322
DavidEdell wants to merge 9 commits intomainfrom
305-rest-api-error-handling

Conversation

@DavidEdell
Copy link
Copy Markdown
Contributor

Updated REST APIs to return correct error codes, and updated dtnma-tools to bring in fixes for SQL concurrency causing reliability issues.

NOTE: Testing is still in progress (a final rebuild test after dtnma-tools changes were merged into main was misbehaving on initial quick look).

…ols to bring in fixes for SQL concurrency causing reliability issues.
@DavidEdell DavidEdell marked this pull request as ready for review March 17, 2026 05:51
@DavidEdell DavidEdell requested a review from a team as a code owner March 17, 2026 05:51
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@BrianSipos
Copy link
Copy Markdown
Collaborator

The compose logs don't say it clearly but the container which is logged as being "... Created" but does not show up as "... Healthy" is the anms-ui one.

@DavidEdell
Copy link
Copy Markdown
Contributor Author

DavidEdell commented Mar 24, 2026

The compose logs don't say it clearly but the container which is logged as being "... Created" but does not show up as "... Healthy" is the anms-ui one.

I noticed that - doubly odd as there haven't been any recent changes within the anms-ui.

I tried another fresh podman build yesterday on my rh VM, this time specifying BUILDAH_FORMAT=docker podman compose --profile full build to force healthcheck availability, and still couldn't reproduce the CI error (podman compose ps showed all containers as healthy).

I also timed the startup, and it came up well within CI's 10 minute timeout window for that step.

There was also an earlier error in podman-CI related to timeouts pulling certain dependencies that resolved on a 'retry failed'. It's increasingly looking like there's something odd with the CI runner VM...

Copy link
Copy Markdown
Collaborator

@BrianSipos BrianSipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes themselves look okay. The anms-core routes that just relay to refdm API should be deprecated for release though.

@BrianSipos
Copy link
Copy Markdown
Collaborator

I tried another fresh podman build yesterday on my rh VM, this time specifying BUILDAH_FORMAT=docker podman compose --profile full build to force healthcheck availability, and still couldn't reproduce the CI error (podman compose ps showed all containers as healthy).
I also timed the startup, and it came up well within CI's 10 minute timeout window for that step.

If there is a more consistent env or command option for podman then the scripts and the CI jobs should use that in the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants