#253 step 7: throw on unset MMGIS_ENVIRONMENT and drop the legacy recipe JSONs - #284
Open
CarsonDavis wants to merge 2 commits into
Open
#253 step 7: throw on unset MMGIS_ENVIRONMENT and drop the legacy recipe JSONs#284CarsonDavis wants to merge 2 commits into
CarsonDavis wants to merge 2 commits into
Conversation
The Terraform module injects MMGIS_ENVIRONMENT into every lean runtime and full mode never reaches this code, so an unset value has no legitimate case. Drop DEFAULT_STACK_NAME_PREFIX and the unset/empty fallback in stackNamePrefix() and throw a loud error instead, matching the existing validation guards.
The legacy staging environment is torn down, so the ecs/ and iam/ recipe JSONs it justified are dead. Remove the seven task and role JSONs, the infrastructure spec tests that read them, and the README regions that documented them, keeping cloudfront-admin.json, cloudfront-function.js, and s3-asset-bucket.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy staging environment is fully torn down, so its two lingering supports come out.
MMGIS_ENVIRONMENTunset now throws instead of falling back.stackNamePrefix()returned the shared legacy prefixmmgis-dashboard-when the variable was unset — a convenience that only the (now-deleted) hand-built staging environment relied on. It now throws, matching the existing regex/length guards. Safe for full/local mode: the publish/dashboard path only mounts underisLean(), where Terraform always injects the variable.infrastructure/{ecs,iam}/*.jsonsnippets mirrored the hand-built environment and no longer describe anything real. Removed, with their coupled tests and the README provenance/placeholder sections. The 3 live-artifact templates (cloudfront-*,s3-asset-bucket.json) stay.Closes the code-side criterion of #253's teardown. 966 tests green.