Replace obsolete kwargs to _add_message & pre-release lint#410
Merged
sadielbartholomew merged 6 commits intoJul 6, 2026
Merged
Conversation
davidhassell
approved these changes
Jul 6, 2026
davidhassell
left a comment
Contributor
There was a problem hiding this comment.
Hi Sadie - following our discussion on Wednesday - this looks great. Thanks
Member
Author
|
Thanks David. Note the linting/pre-commit CI job is failing for due to upstream issues not related to the PR:
so we can ignore that. Merging now. |
sadielbartholomew
added a commit
that referenced
this pull request
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue from a partially bodged merge conflict resolution in #373, namely that some of the new & old calls to
_add_messagewere using the old API wherevariablewas a valid keyword - in that PR it was updated to the more informativedirect_parent_ncvar(see this commit which outlines the change to the method itself) but in resolving conflicts in that PR somehow some of the old code was left in there, resulting in errors such as:downstream in cf-python code.
Note testing on the conformance checking will be extended in coverage etc. in future - this ideally would have been caught in the cfdm test suite pre-release, but at present it isn't being detected and only through the cf-python tutorial code testing did we notice it.
Also includes pre-bug-fix-release linting, mostly to fix docstring line wrapping though note like in the cf-python pre-commit config. I've disabled
docsformatterwhich is very strict and would change most Python modules in the codebase - so is too much clutter for now. (We can configure and re-enable in future.)