Skip to content

Conversation

@Vox-Ben
Copy link
Contributor

@Vox-Ben Vox-Ben commented Jan 20, 2026

Description

Creates the controller class that orchestrates calls to the other gateway components and to the GP provider

Context

This module is needed so that we have something that actually calls all the components that we need to call and manages their responses.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@Vox-Ben Vox-Ben requested a review from a team as a code owner January 20, 2026 16:03
@Vox-Ben Vox-Ben force-pushed the feature/GPCAPIM-255_controller_module branch from 1ab29e7 to fc5b194 Compare January 20, 2026 16:04
@github-actions
Copy link

ALB Target: arn:aws:elasticloadbalancing:eu-west-2:900119715266:targetgroup/gpcapim-255-controller-module/b4084f2f62453ce7
Preview URL: https://feature-gpcapim-255-controller-module.dev.endpoints.clinical-data-gateway.national.nhs.uk

@github-actions
Copy link

ALB Target: arn:aws:elasticloadbalancing:eu-west-2:900119715266:targetgroup/gpcapim-255-controller-module/b4084f2f62453ce7
Preview URL: https://feature-gpcapim-255-controller-module.dev.endpoints.clinical-data-gateway.national.nhs.uk

self,
trace_id: str, # NOSONAR S1172 (ignore in stub)
body: json_str, # NOSONAR S1172 (ignore in stub)
nhsnumber: str, # NOSONAR S1172 (ignore in stub)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nhsnumber won't be needed for this method

Suggested change
nhsnumber: str, # NOSONAR S1172 (ignore in stub)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get the patient's records without the NHS number? How does the provider know which patient's records to send us?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's contained as a parameter in the request body, which we just forward on.

@github-actions
Copy link

ALB Target: arn:aws:elasticloadbalancing:eu-west-2:900119715266:targetgroup/gpcapim-255-controller-module/b4084f2f62453ce7
Preview URL: https://feature-gpcapim-255-controller-module.dev.endpoints.clinical-data-gateway.national.nhs.uk

@github-actions
Copy link

ALB Target: arn:aws:elasticloadbalancing:eu-west-2:900119715266:targetgroup/gpcapim-255-controller-module/b4084f2f62453ce7
Preview URL: https://feature-gpcapim-255-controller-module.dev.endpoints.clinical-data-gateway.national.nhs.uk

@github-actions
Copy link

ALB Target: arn:aws:elasticloadbalancing:eu-west-2:900119715266:targetgroup/gpcapim-255-controller-module/b4084f2f62453ce7
Preview URL: https://feature-gpcapim-255-controller-module.dev.endpoints.clinical-data-gateway.national.nhs.uk

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
91.7% Coverage on New Code (required ≥ 95%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants