Skip to content

Conversation

@JamesW1-NHS
Copy link
Contributor

@JamesW1-NHS JamesW1-NHS commented Jan 23, 2026

Summary

  • Routine Change

Specifically designed to fix the issue of hard-coding items in Grafana provisioning files.
The .yml files are not able to read arguments from .tfvars etc., but they are able to accept them when passed in by the Dockerfile; hence the shell script can extract these from .env and pass them to docker build as --build-arg arguments.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-105

dlzhry2nhs
dlzhry2nhs previously approved these changes Jan 23, 2026
@sonarqubecloud
Copy link

@JamesW1-NHS JamesW1-NHS deployed to internal-dev-sandbox January 23, 2026 12:36 — with GitHub Actions Active
@JamesW1-NHS JamesW1-NHS deployed to internal-dev January 23, 2026 12:38 — with GitHub Actions Active
@JamesW1-NHS JamesW1-NHS merged commit 1133721 into staging/VED-15-grafana Jan 23, 2026
17 checks passed
@JamesW1-NHS JamesW1-NHS deleted the VED-105-grafana-docker-3 branch January 23, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants