-
Notifications
You must be signed in to change notification settings - Fork 35
Upgrade to NHS.UK frontend v10.3 #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b5a442f to
ba70e15
Compare
ba70e15 to
fac75a6
Compare
|
|
Not sure if you'd be up for reviewing this please @mikeathan-nhs? I could do with adding some extra bits to the migration guide but the component changes are ready to review There's only one complication I'd like another pair of eyes on Heading elements versus propsFor accessibility reasons, repetitive card actions repeat the heading in visually hidden text But due to Before<Card>
<Card.Heading>Example heading</Card.Heading>
{/* … */}
</Card>After<Card heading="Example heading">
{/* … */}
</Card>Whilst this matches the approach for What do you think? Plenty of other heading/title elements still exist: <Hero.Heading>
<NotificationBanner.Heading>
<NotificationBanner.Title>
<ErrorSummary.Title>
<Panel.Title>
<Tabs.Title> |


This PR upgrades the React components to NHS.UK frontend v10.3
The file upload component, card actions and interruption panel variant are all included