Chore: [AEA-0000] - Simplify main event handler with custom error flow handler #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
connoravo-nhs
previously approved these changes
Jan 21, 2026
wildjames
reviewed
Jan 21, 2026
wildjames
previously approved these changes
Jan 21, 2026
Contributor
wildjames
left a comment
wildjames
left a comment
There was a problem hiding this comment.
I think your PR title sells this one short - this is a great refactoring job, the flow of the handler is so much easier to follow now!
tstephen-nhs
dismissed stale reviews from wildjames and connoravo-nhs
via
c853d49
tstephen-nhs
changed the title
tstephen-nhs
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
Make lambda more maintainable by concentrating on happy path in the event handler and introducing a separate error handler.