Skip to content

Conversation

@sjvrijn
Copy link
Contributor

@sjvrijn sjvrijn commented Jul 30, 2024

Description

pytest-cookies had a cookies_session fixture, but pytest-copie did not yet have an equivalent when first switching from cookiecutter to copier. Since this will be added soon$^\text{tm}$ has recently been added, we can go back to using a dedicated fixture rather than creating such a session scoped template instance ourselves


$^\text{tm}$ once included in pytest-copie, this PR will be marked as ready

@sjvrijn sjvrijn marked this pull request as draft July 30, 2024 15:43
@sjvrijn sjvrijn changed the title Rename template folder and files in preparation of migration to copier Use copie_session fixture Jul 30, 2024
Copy link
Collaborator

@egpbos egpbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be great, but When Is This Coming Exactly?™ :P

Change request: please also remove the here import and the associated dependency (I forget its name).

@sjvrijn
Copy link
Contributor Author

sjvrijn commented Aug 1, 2024

@egpbos good catch, pyprojroot.here references now removed.

Can't say when Soon™ is exactly, but it's active work in progress :)

Base automatically changed from dev to main August 20, 2024 10:11
@sjvrijn sjvrijn force-pushed the use-copie_session-fixture branch 3 times, most recently from 6f7cec0 to f5e8634 Compare February 2, 2025 21:53
@sjvrijn sjvrijn marked this pull request as ready for review February 2, 2025 22:05
@sjvrijn
Copy link
Contributor Author

sjvrijn commented Apr 2, 2025

@egpbos the pytest-copie dependency has been updated so this functionality can be reliably included in the tests. Can you have another look

@sjvrijn sjvrijn force-pushed the use-copie_session-fixture branch from f5e8634 to 982a89e Compare August 14, 2025 18:09
@sjvrijn sjvrijn merged commit 58fa2e6 into main Aug 15, 2025
18 checks passed
@sjvrijn sjvrijn deleted the use-copie_session-fixture branch August 15, 2025 08:06
@egpbos
Copy link
Collaborator

egpbos commented Aug 27, 2025

Thanks for merging this, sorry for not replying :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants