Error out on non-zero unused bit in DER encoding#97
Merged
Conversation
partim
requested changes
May 8, 2026
partim
left a comment
partim
left a comment
Member
There was a problem hiding this comment.
Three things:
- This check also needs to happen in CER mode.
- The check must not happen if
bitsis empty – I suppose the cleanest way is to do anif let Some(ch) = bits.last(). - Particularly in light of the previous item: there should be some cases added to the test at the end of the module.
partim
approved these changes
May 11, 2026
partim
added a commit
that referenced
this pull request
Jun 8, 2026
New * Added `RestrictedString::take_opt_from`. ([#90]) Improvements * `BIT_STRING` parsing now checks that the unused bits are zero in CER and DER modes. ([#97]) Bug fixes * Fixed `Utf8String` potentially accepting invalid UTF-8. ([#91] by [@sumleo]) * Fixed a panic in `Unsigned::from_bytes` when the input is all zero. ([#92] by [@sumleo]) * Fixed incorrect bounds check in `BitString::bit`. ([#93] by [@sumleo]) * Added character set validation to `FromStr` impl for `NumericString`, `PrintableString`, and `Ia5String`. ([#95] by [@sumleo])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.