fix(recipes): remove deprecated fully_shard kwargs (check_for_nan_in_grad, grad_reduce_in_fp32)#1594
Closed
svc-bionemo wants to merge 1 commit into
Closed
Conversation
…grad, grad_reduce_in_fp32) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: svc-bionemo <267129667+svc-bionemo@users.noreply.github.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
|
closing in favor of #1585 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes nightly CI failures caused by updated
megatron-fsdppackage that removed thecheck_for_nan_in_gradandgrad_reduce_in_fp32keyword arguments fromfully_shard().Failures Fixed
TypeError: fully_shard() got an unexpected keyword argument 'check_for_nan_in_grad'TypeError: fully_shard() got an unexpected keyword argument 'check_for_nan_in_grad'TypeError: fully_shard() got an unexpected keyword argument 'grad_reduce_in_fp32'Changes
check_for_nan_in_gradandgrad_reduce_in_fp32fromfully_shard_kwargsin geneformer and esm2 hydra configsgrad_reduce_in_fp32from vit config files andtrain.pyNot Fixed (infrastructure issue)
AssertionError: Minimum required nvidia-resiliency-ext package version is 0.6.0.— This is a container image issue requiringnvidia-resiliency-ext>=0.6.0to be installed.CI Run
https://github.com/NVIDIA-BioNeMo/bionemo-framework/actions/runs/26814311142