Fix super3 data prep rl subgroup bootstrap#269
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
Contributor
|
Need signoff. |
(cherry picked from commit 7e57c65) Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
fallintoplace
force-pushed
the
fix/super3-data-prep-rl-subgroup
branch
from
July 8, 2026 18:46
b877002 to
4e12cec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
super3 data prep rlas a Typer subgroup instead of importing the shadowedprep.rlmodule surfacesrc/nemotron/cli/commands/super3/data/prep/rl.pydispatcher and add explicitrlvr,swe1,swe2, andrlhfdata-prep command modules under therl/packagesuper3 data prep rlentrypointRoot cause
src/nemotron/cli/commands/super3/data/prep/_typer_group.pyimportedMETAandrlfromnemotron.cli.commands.super3.data.prep.rl, but that path now has both a siblingrl.pyfile and anrl/package. Python resolves the package first, and the package only exportedrl_app, so the Super3 data-prep CLI broke during import/bootstrap.Impact
After this change,
super3 data prep rlloads as the intended subgroup and exposes all documented stage-specific subcommands:rlvrswe1swe2rlhfValidation
python3 -m compileall src/nemotron/cli/commands/super3/data/prep tests/recipes/super3/test_cli.pyuv run --no-project --with pytest --with "nemo-run @ git+https://github.com/NVIDIA-NeMo/Run.git@main" --with typer --with rich --with textual --with fsspec --with numpy --with pyarrow --with xxhash --with "transformers>=4.57.6,<5.0" --with "huggingface_hub>=0.20.0" --with "datasets>=2.14.0" --with pyyaml --with tomlkit --with colorama --with "wandb>=0.23.1" --with jinja2 --with pydantic --with "pydantic-settings>=2.12.0" --with omegaconf env PYTHONPATH=src pytest tests/recipes/super3/test_cli.py