test: fix collection errors in kit and recipes tests#283
Open
andrewwhitecdw wants to merge 4 commits into
Open
test: fix collection errors in kit and recipes tests#283andrewwhitecdw wants to merge 4 commits into
andrewwhitecdw wants to merge 4 commits into
Conversation
- Update test_resolvers_pre_init.py to import from nemo_runspec.config.resolvers - Update test_utils.py to import from nemo_runspec.utils - Fix FakeWandb/FakeArtifact mocks for current wandb.Api signature - Fix super3 data prep CLI to register rl as a typer subgroup, matching the pattern used in super3/_typer_group.py Signed-off-by: Andrew White <andrewh@cdw.com>
Contributor
|
/claude review this bad boy |
Contributor
|
/claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes three collection errors:
• tests/kit/test_resolvers_pre_init.py — imports now point to
nemo_runspec.config.resolvers, and the fake W&B mocks were updated for
the current wandb.Api(timeout=...) signature.
• tests/kit/cli/test_utils.py — imports now point to nemo_runspec.utils.
• src/nemotron/cli/commands/super3/data/prep/_typer_group.py — registers
the rl package as a Typer subgroup (add_typer) instead of a recipe
command, matching the pattern in super3/_typer_group.py.
Verified:
uv run pytest tests/kit/test_resolvers_pre_init.py tests/kit/cli/test_utils.py -v # 48 passed